[PATCH] D27810: FileManager: mark virtual file entries as valid entries

Cameron via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 13:08:34 PDT 2017

cameron314 added a comment.

The `IsValid = true` line coincidentally fixes a tangentially related bug -- see https://reviews.llvm.org/D20338 (in which I tried to introduce the same fix almost a year earlier, but nobody accepted the review). I guess I have to maintain the test for that case out of tree, though I could try to upstream it again (however, given that it's now passing with your change, I don't have much hope of it being accepted).


More information about the cfe-commits mailing list