[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 09:02:06 PDT 2017

lebedev.ri added a comment.

In https://reviews.llvm.org/D37381#858800, @brad.king wrote:

> > Tests?
> `make check` didn't regress from this.

Which is the problem.

Say this gets committed, and then someone else for some reason reverts part of the patch.
Normally, tests should catch that. But as you have stated yourself, no tests failed because of this...

> This behavior difference is not observable from within Clang itself, only in external applications that use SuppressAllDiagnostics while forcing definition of implicit members.  Adding a test will require reproducing a chunk of the application code in the test suite to create the appropriate CompilerInstance.  I'd be happy to do that to keep this working in the future, but where would be the appropriate place?
> BTW, I'd like to see this integrated in the `release_50` branch because this regression breaks my application that works with 3.6, 3.7, 3.8, 3.9, and 4.0.


More information about the cfe-commits mailing list