[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

[Brad King via Phabricator via cfe-commits]

brad.king created this revision.

In commit r303930 (Switch from using a DiagnosticTrap and a note...,
2017-05-25) use of DiagnosticErrorTrap was removed because it was no
longer needed to detect whether to add a diagnostic note.  However, the
trap was also necessary to correctly detect and mark invalid special
members under `Sema.getDiagnostics().setSuppressAllDiagnostics(true)`.
Restore use of the trap to fix semantic checking when diagnostics are
suppressed.

This is useful for external tools that need to detect the set of valid
special members without issuing diagnostics on the invalid ones.


https://reviews.llvm.org/D37381

Files:
  lib/Sema/SemaDeclCXX.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37381.113542.patch
Type: text/x-patch
Size: 4648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170901/2a5f168f/attachment-0001.bin>