[PATCH] D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 1 07:38:31 PDT 2017
klimek added a comment.
One of my main concerns is still that I don't see the need for all the template magic yet :) Why doesn't everybody use the RefactoringResult we define here?
================
Comment at: test/Refactor/LocalRename/Field.cpp:4
+class Baz {
+ int /*range=*/Foo; // CHECK: symbol [[@LINE]]:17 -> [[@LINE]]:20
+public:
----------------
Does this just test the selection?
================
Comment at: tools/clang-refactor/ClangRefactor.cpp:135
+
+class ToolRefactoringEngine final : public RefactoringEngine {
+public:
----------------
Can we use composition instead of inheritance here?
Repository:
rL LLVM
https://reviews.llvm.org/D36574
More information about the cfe-commits
mailing list