[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:337
+    // Fill in the kind field of the CompletionItem.
+    Item.kind = getKind(Result.CursorKind);
+
----------------
ilya-biryukov wrote:
> Could we also set `Item.filterText` to completion item name?
> So that various pieces of function signature would not match on user input.
After some investigation: `CK_TypedText` chunks are exactly the things that should go into `filterText`.
Also, VSCode seems to ignore `filterText` right now, but that's certainly a bug in VSCode, I still propose to set `filterText` properly.


https://reviews.llvm.org/D37101