[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 31 09:56:38 PDT 2017

arphaman added a comment.

In https://reviews.llvm.org/D37291#857727, @klimek wrote:

> Thanks! I think this makes the code easier to understand. Now my remaining question is why the ResultType is templates vs. also being an interface (sorry for being late, was out on vacation the past 2 weeks :)

ResultType is typically a vector of `AtomicChange` or `SymbolOccurrences` which we can't subclass from an interface. Or are you wondering if `AtomicChange` and `SymbolOccurrence` should subclass from a common interface? It could potentially be useful, but I'm not sure if there could be that many methods that would go into the interface.


More information about the cfe-commits mailing list