[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 31 07:48:19 PDT 2017

klimek added a comment.

Thanks! I think this makes the code easier to understand. Now my remaining question is why the ResultType is templates vs. also being an interface (sorry for being late, was out on vacation the past 2 weeks :)

Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:30
+  /// the source selection has no overlap at all with any relevant AST nodes.
+  virtual void handleInitiationFailure() = 0;
ioeric wrote:
> Just wondering if it is possible to provide more information about the initiation failure to the handler?
Also, why is initiationFailure not simply handled via handleError?


More information about the cfe-commits mailing list