[PATCH] D37182: [libcxx] Special visibility macros for the experimental library
Hamza Sood via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 31 07:32:00 PDT 2017
hamzasood updated this revision to Diff 113399.
hamzasood added a comment.
Herald added a subscriber: mgorny.
I've added a couple more Windows macro-related fixes to the experimental library.
Most importantly is the change to _LIBCPP_BUILDING_LIBRARY. Previously _LIBCPP_BUILDING_LIBRARY was defined for every source file, including files destined for the experimental library. As a result of this, non-experimental APIs were marked as dllexport when compiling the experimental library (which led to link errors whenever experimental code uses symbols from the regular libc++ library).
I've changed it so that _LIBCPP_BUILDING_LIBRARY is only defined for non-experimental source files, and _LIBCPPX_BUILDING_LIBRARY is defined for experimental source files (that macro isn't currently used for anything, it's mainly there for consistency).
I've also added the needed MSVCRT defines to the experimental code too, so that there won't be a bunch of warnings about using "deprecated" functions etc.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 156922 bytes
Desc: not available
More information about the cfe-commits