[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 14:13:22 PDT 2017

mstorsjo added inline comments.

Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2994
+          CGM.getContext().getTargetInfo().getTriple().isOSWindows();
+      // MinGW always uses LinkOnceODRLinkage for type info.
+      if (RD->isDynamicClass() && !IsMinGW)
Thanks for having a look at this!

When giving this a second thought now, should we perhaps skip the check for `Environment == GNU` altogether? Or should `xxx-windows-itanium` be different by restricting this behaviour strictly to GNU (does it matter)?

And given the existing test case that you added with the previous form of this code, and the new test I'm adding here, are there any other odd corner cases I should check?


More information about the cfe-commits mailing list