[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Boris Kolpackov via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 11:52:54 PDT 2017

Victor Leschuk <vleschuk at accesssoftek.com> writes:

> Hello Boris, looks like this revision broke tests on our win10 builder:
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760
> Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp
> I had to revert this revision. Could you please take a look?

Sorry about that.

I took a look and it seems the problem is with the test's path regex:


Which, on Windows, is being matched against a path like this:


It looks like the "canonical" fix for this is to use [/\\].

What is the protocol in this situation? Should I fix the test and then
re-apply my patch?


More information about the cfe-commits mailing list