[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 05:48:15 PDT 2017

aaron.ballman added a comment.

> I do agree that it makes sense to keep it as low as possible, but also i see a clear logic between all thee current checks:

Thank you for the explanation. I think that makes sense to me, but I'd like to hear from @alexfh before accepting.

Comment at: test/clang-tidy/check_clang_tidy.py:79-80
   except subprocess.CalledProcessError as e:
     print('clang-tidy failed:\n' + e.output.decode())
   print('------------------------ clang-tidy output -----------------------\n' +
I think the text should be rephrased to "CHECK-FIXES, CHECK-MESSAGES, or CHECK-NOTES not found in the input"



More information about the cfe-commits mailing list