[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 05:30:15 PDT 2017


lebedev.ri added a comment.

In https://reviews.llvm.org/D36892#856501, @JonasToth wrote:

> Note can be handled right now as well.


Yes. Adding this new prefix is about adding `-implicit-check-not=notes`.
I.e. if you use `CHECK-MESSAGES`, then it will only enforce you to have check-lines for all the `error: ` and `warning: ` the check outputs.
It does *not* enforce that all the `note: ` are to be handled. `CHECK-NOTES` however would enforce that.

> E.g.
> 
>   // CHECK-MESSAGES: [[@LINE-2]]:3: note: type deduction did not result in an owner
> 
> would the patch handle the codelocation correctly?

I'm not sure what is the question to be honest. This does not change anything about codelocation handling


Repository:
  rL LLVM

https://reviews.llvm.org/D36892





More information about the cfe-commits mailing list