[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

[Raoul Wols via Phabricator via cfe-commits]

rwols updated this revision to Diff 113219.
rwols added a comment.

Tidy up snippet handling

- Put CK_Informative chunks in the label
- Assert that there's at most one CK_ResultType chunk
- CK_CurrentParameter never occurs while collecting completions, only while handling overloads.
- For CK_VerticalSpace, use a space for the label (but a newline for the insertText).
- Move the SnippetEscape function outside the class and into an unnamed namespace.


https://reviews.llvm.org/D37101

Files:
  clangd/ClangdUnit.cpp
  clangd/Protocol.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37101.113219.patch
Type: text/x-patch
Size: 9499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170830/8e43c433/attachment.bin>