[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Boris Kolpackov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 01:13:18 PDT 2017

boris marked 2 inline comments as done.
boris added inline comments.

Comment at: lib/Frontend/CompilerInvocation.cpp:986
+    if (Val.find('=') == StringRef::npos)
+      Opts.ExtraDeps.push_back(Val);
+  }
rsmith wrote:
> Does a module file specified via `-fmodule-file=foo=foo.pcm` get included in the dep file if it is used? (If not, I'm happy for that to be fixed in a separate change, but it does need to be fixed for depfile-based build systems.)
No, currently it does not and neither a module file that is discovered via -fprebuilt-module-path. I think if we are doing this, then we should do for both cases. What do you think?


More information about the cfe-commits mailing list