[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 14:07:37 PDT 2017

hans added a comment.

In https://reviews.llvm.org/D26764#855791, @eugenis wrote:

> IMHO it was a very bad idea to include the "architecture name" (not even a target triple!) in the library path in the first place. No one else does that. GCC made the right choice and called theirs "libasan.so".
> My plan is to tweak the code that sets the library name to use i686 when the target is i386 and the os is android, both in compiler-rt and in clang. There will be no duplicate targets.

Sounds good to me. Let me know if you think this will take a while and we should revert to green in the meantime.



More information about the cfe-commits mailing list