[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

Kostya Serebryany via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 11:41:58 PDT 2017

kcc added inline comments.

Comment at: clang/lib/Driver/SanitizerArgs.cpp:297
                             CoverageTraceCmp | CoveragePCTable;
+#if !defined(__APPLE__)
+        // Due to TLS differences, stack depth tracking is disabled on Mac.
please use if(SomeCondition) instead of #if

In general: 99% of cases where you may want to use #if -- you shouldn't

Comment at: compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc:20
 #include "sanitizer_symbolizer.h"
+#include <cstdint>
no standard hearder in this files. Just use the 'uptr' type. 


More information about the cfe-commits mailing list