[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 11:27:23 PDT 2017

hans added inline comments.

Comment at: compiler-rt/trunk/lib/asan/scripts/asan_device_setup:98
     if [[ $_ABI == x86* ]]; then
-        _ARCH=i686
+        _ARCH=i386
     elif [[ $_ABI == armeabi* ]]; then
There are lots of copies of this script in various project that now all need to be updated (searching the web for asan_device_setup shows some).

For me personally, this means updating Chromium (also the build system needs an update) to handle different names before and after this revision.

Do you have any suggestions for how we should handle this rename? Is there some backwards-compatibility fix we could do?

As you noticed this broke some LLVM buildbots. It also broke Chromium buildbots, and I suppose other projects which use asan. I'm wondering if the fallout is worth the benefits here.



More information about the cfe-commits mailing list