[PATCH] D37005: [clang-diff] Initial implementation of patching

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 05:36:34 PDT 2017

arphaman added inline comments.

Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73
+  /// Empty (invalid) SyntaxTree.
+  SyntaxTree();
Why do you need to create an empty tree? What about using llvm::Optional instead?

Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:82
+  SyntaxTree(SyntaxTree &&Other);
+  SyntaxTree &operator=(SyntaxTree &&Other);
+  explicit SyntaxTree(const SyntaxTree &Other);
It's fine to have = default in the header


More information about the cfe-commits mailing list