[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 06:14:49 PDT 2017

xazax.hun added a comment.

In https://reviews.llvm.org/D37023#853941, @NoQ wrote:

> Thank you for the review!
> > Though it looks like some of the cases covered in the code do not have corresponding tests (e.g.: the parenexprs).
> These are covered by tests in `inline-defensive-checks.c:150,156,169,179` (old code had `IgnoreParenCasts`). This function is actually used a lot (even more so since https://reviews.llvm.org/D32291), and seems fairly well-tested, so i felt relatively safe when refactoring it.

Oh, indeed, thanks :)

>> But I wonder if there could be some cases where we have such cast earlier than expected.
> I'd love to know :o

I started to check some of the cases I was thinking about, but all of them looked fine :)


More information about the cfe-commits mailing list