[PATCH] D37005: [clang-diff] Initial implementation of patching
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 28 03:50:16 PDT 2017
arphaman added inline comments.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:658
+ SourceRange Range;
+ if (auto *Arg = N.ASTNode.get<TemplateArgument>())
+ Range = TemplateArgumentLocations.at(&N - &Nodes[0]);
----------------
You can drop the `auto *Arg` since Arg is unused.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:1305
+struct Patcher {
+ SyntaxTree::Impl &ModelSrc, &ModelDst, &Target;
----------------
Please move the patcher into a new file.
https://reviews.llvm.org/D37005
More information about the cfe-commits
mailing list