[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In https://reviews.llvm.org/D37101#853509, @rwols wrote:

> After digging into VSCode, I now think that presenting snippets is the wrong way forward, and I believe the right way is to implement the `signatureHelpProvider` protocol for method/function parameters. See: https://github.com/Microsoft/vscode-docs/blob/master/docs/extensionAPI/language-support.md#help-with-function-and-method-signatures.
>
> I'll update this diff accordingly.


I still think having support for snippets is useful in completion. Let's not have snippets for functions and only present them for `RK_Pattern`s.

Signature help is useful, but it's a separate feature and should also go in as a separate commit.
For example, consider the differences between completion and signature help.

  vector<int> vec;
  vec.push_back(/*cursor*/

In that case,

- signature help must show all overloads of push_back, show documentation for the first parameter, if any;
- code completion must show global completions.


https://reviews.llvm.org/D37101