[PATCH] D36685: [clang-diff] HTML diff navigation

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

LGTM. There are some unrelated highlighting bugs in HTML though, for example if you take:

before:

  int foo();
  
  void bar(int x) {
    switch (x) {
    case 0:
      bar(2);
    }
  }

after:

  void bar(int x) {
    switch (x) {
    case 4:
      bar(2);
      break;
    case 1:
      bar(3);
      break;
    }
  }
  
  int foo();
  
  int zed();

Then first time `bar` is selected in the new source the whole function is highlighted. Then, if you select `4` in the new source and then re-select the function `bar` again, `bar` is highlighted, but there's a gap where `4` is.


https://reviews.llvm.org/D36685