[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added a comment.

Performance-wise the change is fine because it does the same amount of work, but I would prefer someone to audit the code to make sure that we aren't uniquing a node while we still want to make changes to it. Unfortunately testcases for these issues will involve impossibly nested C++ so it may take a while to find a counterexample in the wild. That's why I'd rather read the code instead :-)


https://reviews.llvm.org/D37038