r311240 - [clang-diff] Fix warning about useless comparison

Johannes Altmanninger via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 19 06:29:45 PDT 2017


Author: krobelus
Date: Sat Aug 19 06:29:44 2017
New Revision: 311240

URL: http://llvm.org/viewvc/llvm-project?rev=311240&view=rev
Log:
[clang-diff] Fix warning about useless comparison

Modified:
    cfe/trunk/tools/clang-diff/ClangDiff.cpp

Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-diff/ClangDiff.cpp?rev=311240&r1=311239&r2=311240&view=diff
==============================================================================
--- cfe/trunk/tools/clang-diff/ClangDiff.cpp (original)
+++ cfe/trunk/tools/clang-diff/ClangDiff.cpp Sat Aug 19 06:29:44 2017
@@ -106,7 +106,7 @@ getAST(const std::unique_ptr<Compilation
 static char hexdigit(int N) { return N &= 0xf, N + (N < 10 ? '0' : 'a' - 10); }
 
 static void printJsonString(raw_ostream &OS, const StringRef Str) {
-  for (char C : Str) {
+  for (signed char C : Str) {
     switch (C) {
     case '"':
       OS << R"(\")";




More information about the cfe-commits mailing list