[PATCH] D36882: [clang-proto-fuzzer] Allow user-specified compiler arguments.

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 11:17:01 PDT 2017


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:33
+  for (I = 1; I < *argc; I++)
+    if (llvm::StringRef((*argv)[I]).equals("-ignore_remaining_args=1"))
+      break;
----------------
maybe just strcmp


================
Comment at: clang/tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:35
+      break;
+  for (I++; I < *argc; I++)
+    CLArgs.push_back((*argv)[I]);
----------------
you can put second loop inside of the if just before the break and avoid top level var "I"


https://reviews.llvm.org/D36882





More information about the cfe-commits mailing list