[PATCH] D36820: [Bash-autocompletion] Add support for -std=

[Rui Ueyama via Phabricator via cfe-commits]

ruiu added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2254
+  ValuesCode<[{
+const char* Values =
+#define LANGSTANDARD(id, name, lang, desc, features) name ","
----------------
ruiu wrote:
> I think Raphael suggested indenting embedded code with at least 2 spaces. I think you want to indent it with 4 spaces so that it looks better.
`const char* Values` -> `const char *Values`


================
Comment at: clang/include/clang/Driver/Options.td:2254-2258
+const char* Values =
+#define LANGSTANDARD(id, name, lang, desc, features) name ","
+#define LANGSTANDARD_ALIAS(id, alias) alias ","
+#include "clang/Frontend/LangStandards.def"
+;
----------------
I think Raphael suggested indenting embedded code with at least 2 spaces. I think you want to indent it with 4 spaces so that it looks better.


================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314
       for (const std::string &Pref : R.getValueAsListOfStrings("Prefixes")) {
-        OS << "bool ValuesWereAdded = ";
+        OS << "ValuesWereAdded = ";
         OS << "Opt.addValues(";
----------------
Why do you have to change this? The previous code looks nicer.


https://reviews.llvm.org/D36820