[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.
Chih-Hung Hsieh via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 16 11:04:49 PDT 2017
chh added inline comments.
================
Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31
+ replaceFunc(Result, /*WarningMsg=*/
+ "prefer epoll_create() to epoll_create1() "
+ "because epoll_create1() allows "
+ "EPOLL_CLOEXEC", /*FixMsg=*/
+ "epoll_create1(EPOLL_CLOEXEC)");
----------------
alexfh wrote:
> nit: Please remove argument comments, they don't add any useful information.
Done.
Repository:
rL LLVM
https://reviews.llvm.org/D35367
More information about the cfe-commits
mailing list