[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 16 08:30:33 PDT 2017
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
================
Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31
+ replaceFunc(Result, /*WarningMsg=*/
+ "prefer epoll_create() to epoll_create1() "
+ "because epoll_create1() allows "
+ "EPOLL_CLOEXEC", /*FixMsg=*/
+ "epoll_create1(EPOLL_CLOEXEC)");
----------------
nit: Please remove argument comments, they don't add any useful information.
https://reviews.llvm.org/D35367
More information about the cfe-commits
mailing list