[PATCH] D36715: [clang] minor cleanup in clang/tooling/refactoring
Alexander Shaposhnikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 15 12:24:58 PDT 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310948: [clang] Code cleanup in clang/tooling (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D36715?vs=111078&id=111229#toc
Repository:
rL LLVM
https://reviews.llvm.org/D36715
Files:
cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
Index: cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
===================================================================
--- cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
+++ cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
@@ -29,7 +29,7 @@
/// \endcode
class SymbolName {
public:
- SymbolName(StringRef Name) {
+ explicit SymbolName(StringRef Name) {
// While empty symbol names are valid (Objective-C selectors can have empty
// name pieces), occurrences Objective-C selectors are created using an
// array of strings instead of just one string.
Index: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
===================================================================
--- cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -53,7 +53,7 @@
}
Changes.push_back(std::move(Change));
}
- return Changes;
+ return std::move(Changes);
}
/// Takes each atomic change and inserts its replacements into the set of
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36715.111229.patch
Type: text/x-patch
Size: 1085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170815/31403a8f/attachment.bin>
More information about the cfe-commits
mailing list