[PATCH] D35670: [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer

[Peter Szecsi via Phabricator via cfe-commits]

szepet added inline comments.


================
Comment at: include/clang/Analysis/ProgramPoint.h:658
 
+class LoopExit : public ProgramPoint {
+public:
----------------
dcoughlin wrote:
> Can you add a comment explaining what meaning of this program point is.
Can you help me with that? I am not sure what is important to say about this point to understand it better than from its name.


================
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:586
 
+  if ((*Block)[Idx].getKind() == CFGElement::LoopExit) {
+    WList->enqueue(N, Block, Idx+1);
----------------
dcoughlin wrote:
> I'm surprised both this and the checks for N's location above are needed. How does this arise?
We don't need both of the checks, I just left it by mistake.


https://reviews.llvm.org/D35670