[PATCH] D36185: [clang-diff] Fix similarity computation
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 14 06:06:33 PDT 2017
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:738
+ }
+ double Denominator = T1.getNumberOfDescendants(Id1) - 1 +
+ T2.getNumberOfDescendants(Id2) - 1 - CommonDescendants;
----------------
Can denominator even be negative here? If no, please assert correspondingly.
https://reviews.llvm.org/D36185
More information about the cfe-commits
mailing list