[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.

LGTM



================
Comment at: clang-tidy/android/CloexecCheck.h:91
+  /// Helper function to get the spelling of a particular argument.
+  StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result,
+                           int N) const;
----------------
yawanng wrote:
> hokein wrote:
> > This method seems only be used in one check. Maybe move it to the implementation of that specific check? And you can make the  private members `FuncBindingStr` and `FuncDeclBindingStr` to protected member.
> Actually, this  method will be used in three checks. 
Ah, ok. Sorry for missing it.


https://reviews.llvm.org/D35364