[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 11 23:31:45 PDT 2017


mgorny requested changes to this revision.
mgorny added a comment.
This revision now requires changes to proceed.

Also, I think that if you're splitting them up, it'd also logical to move them into a subdirectory, `x86-common` maybe.



================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223
+  cpu_model.c
+  divxc3.c
+  fixxfdi.c
----------------
This and the following files have only:

```
#if !_ARCH_PPC
```

so I suppose it's currently included on more targets than x86. If it's really not useful there, I think it'd be better to update the `#if`s first (and preferably get the author to review).


https://reviews.llvm.org/D36555





More information about the cfe-commits mailing list