[PATCH] D36397: [clangd] Fixed a data race.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 11 06:58:29 PDT 2017


ilya-biryukov added a comment.

A follow-up after discussion offline: we should make an attempt to simplify the threading code in `ClangdUnit.h` by moving the async worker loop of `CppFile` into the class itself, rather than relying on external scheduling to do the right thing.
@klimek, are there any other issues we need to address in this specific patch or are we good to go with submitting it?


https://reviews.llvm.org/D36397





More information about the cfe-commits mailing list