[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Aleksey Shlyapnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 10 08:54:23 PDT 2017


alekseyshl added a comment.

In https://reviews.llvm.org/D29660#838150, @gtbercea wrote:

> First of all, I apologize if I've upset you with my previous post. I am actively working on understanding what is causing these issues. It is not my intention to write tests that work on local configurations only. I am upset to see that these tests keep failing for your and maybe other configurations. Without knowing the actual reason of the failures I can only speculate what is going wrong with them hence the flurry of changes.


Thank you, apology accepted. That was exactly my point, not to start a fight, but to emphasize that depending on local configuration is never going to work, you will never be able to see and test all of them. Please disable the test ASAP and until the better way to handle it is determined.


Repository:
  rL LLVM

https://reviews.llvm.org/D29660





More information about the cfe-commits mailing list