[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

[Simon Atanasyan via Phabricator via cfe-commits]

atanasyan added inline comments.


================
Comment at: test/Driver/mips-longcalls-warning.c:1
+// REQUIRES: mips-registered-target
+// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s
----------------
sdardis wrote:
> atanasyan wrote:
> > sdardis wrote:
> > > Can you put this in test/Driver/mips-abicalls-warning.c from the other patch? I'd prefer to keep all the abicalls warnings together rather than separate tests based on the feature the conflict with.
> > > Can you put this in test/Driver/mips-abicalls-warning.c from the other patch?
> > 
> > I can, but in that case it's probably better to join both patches because that patch loses its test.
> > 
> You can do it as an NFC change afterward both commits in that case.
OK. Thanks for review.


Repository:
  rL LLVM

https://reviews.llvm.org/D36551