[PATCH] D36075: [refactor] Initial support for refactoring action rules

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 10 05:46:43 PDT 2017


arphaman updated this revision to Diff 110563.
arphaman edited the summary of this revision.
arphaman added a comment.

- Simplify error/diagnostic handling. Use `DiagnosticOr` instead of `DiagOr<Expected>`.
- Simplify the code for the selection requirements by removing lambda deducers and instead using special classes for requirements instead of lambdas/functions.
- Rename `selectionRequirement` to `requiredSelection`


Repository:
  rL LLVM

https://reviews.llvm.org/D36075

Files:
  include/clang/Basic/AllDiagnostics.h
  include/clang/Basic/CMakeLists.txt
  include/clang/Basic/Diagnostic.td
  include/clang/Basic/DiagnosticIDs.h
  include/clang/Basic/DiagnosticOr.h
  include/clang/Basic/DiagnosticRefactoringKinds.td
  include/clang/Basic/LLVM.h
  include/clang/Tooling/Refactoring/AtomicChange.h
  include/clang/Tooling/Refactoring/RefactoringActionRules.h
  include/clang/Tooling/Refactoring/RefactoringDiagnostic.h
  include/clang/Tooling/Refactoring/RefactoringOperationController.h
  include/clang/Tooling/Refactoring/RefactoringResult.h
  include/clang/Tooling/Refactoring/SourceSelectionConstraints.h
  lib/Basic/DiagnosticIDs.cpp
  tools/diagtool/DiagnosticNames.cpp
  unittests/Tooling/CMakeLists.txt
  unittests/Tooling/RefactoringActionRulesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36075.110563.patch
Type: text/x-patch
Size: 36557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170810/db829201/attachment-0001.bin>


More information about the cfe-commits mailing list