[PATCH] D9912: PR20958 Allow redeclaration of type-generic builtins
Ilya Palachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 10 02:52:00 PDT 2017
ilya-palachev added a comment.
Hi! Thanks for this patch.
We're building Android6 with Clang (in order to apply static analyzer on it), and without this patch we've 613 build failures. This patch helps to get rid of 521 of those build failures (85%).
"Works for me".
================
Comment at: lib/Sema/SemaDecl.cpp:1758
+ }
+
+ QualType QT1 = FPT->getParamType(0);
----------------
Trailing space
================
Comment at: lib/Sema/SemaDecl.cpp:1763
+ ArgTypes.push_back(QT2);
+
+ if (QT1->isRealFloatingType() && QT2->isRealFloatingType()) {
----------------
Ditto
================
Comment at: lib/Sema/SemaDecl.cpp:1775
+ << II->getName()
+ << QT1.getAsString();
+ return DefaultFunctionType;
----------------
Ditto
================
Comment at: lib/Sema/SemaDecl.cpp:1837
+ case Builtin::BI__builtin_isnan:
+ case Builtin::BI__builtin_signbit:
+ Diag(Loc, diag::err_incorrect_args_builtin_redecl)
----------------
Ditto
https://reviews.llvm.org/D9912
More information about the cfe-commits
mailing list