[PATCH] D35932: [clang-tidy] Add integer division check

Reka Kovacs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 10 02:32:56 PDT 2017


rnkovacs updated this revision to Diff 110539.
rnkovacs marked 3 inline comments as done.
rnkovacs edited the summary of this revision.
rnkovacs added a comment.

Thanks for the comments. I improved the docs and truncated the messages in the test file.

We also had concerns about the nested `hasAncestor` matchers but thought that it might be worth a try. If this solution proves to cause too much of a performance burden I can rewrite it using RAVs.


https://reviews.llvm.org/D35932

Files:
  clang-tidy/bugprone/BugproneTidyModule.cpp
  clang-tidy/bugprone/CMakeLists.txt
  clang-tidy/bugprone/IntegerDivisionCheck.cpp
  clang-tidy/bugprone/IntegerDivisionCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/bugprone-integer-division.rst
  docs/clang-tidy/checks/list.rst
  test/clang-tidy/bugprone-integer-division.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35932.110539.patch
Type: text/x-patch
Size: 11637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170810/1cde5392/attachment-0001.bin>


More information about the cfe-commits mailing list