[PATCH] D36171: AMDGPU: Use direct struct returns

[Brian Sumner via Phabricator via cfe-commits]

b-sumner added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:7571
+
+      // XXX: Should this be i64 instead, and should the limit increase?
+      llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext());
----------------
What we do here depends on NumRegsLeft when the block is entered and NumRegs.  If NumRegsLeft >= NumRegs then we just need 2 adjacent registers.  If NumRegsLeft == 1 and NumRegs == 2, then do we pass the low half in a register and the upper half in memory, or all of it in memory?  Anyway, I think NumRegsLeft shouldn't be updated until we know it's OK, and then we don't need the min().


https://reviews.llvm.org/D36171