[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 10:43:22 PDT 2017


dblaikie added a comment.

Looks plausible (not sure how nice it is to use the llvm::Module itself to communicate the file name to this bit of logic - I'll leave that to Richard Smith to judge, I think)



================
Comment at: test/CodeGen/debug-info-preprocessed-file.i:10
+// RUN: %clang -g -c -S -emit-llvm -o - %s | FileCheck %s
+// CHECK: !DIFile(filename: "/foo/bar/preprocessed-input.c"
----------------
Should probably be a bit more specific in the check - verifying that the DICompileUnit's DIFile is the one you're checking here. (not that there's any other DI* that would have a DIFile here, but still)


https://reviews.llvm.org/D36474





More information about the cfe-commits mailing list