[PATCH] D35755: [Solaris] gcc toolchain handling revamp
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 8 07:46:25 PDT 2017
aaron.ballman added inline comments.
================
Comment at: lib/Driver/ToolChains/Gnu.h:253
+ void AddDefaultGCCPrefixes(const llvm::Triple &TargetTriple,
+ SmallVectorImpl<std::string> &Prefixes,
----------------
fedor.sergeev wrote:
> aaron.ballman wrote:
> > Might as well drop the `llvm::` since the namespace isn't used for `SmallVectorImpl`.
> suggested change caused a build failure since Triple resolves into Toolchain::Triple data member, not to llvm::Triple.
That's really good to know, thanks (and sorry for the churn)!
https://reviews.llvm.org/D35755
More information about the cfe-commits
mailing list