[PATCH] D36261: [clangd] Use multiple working threads in clangd.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 01:50:47 PDT 2017


ilya-biryukov added a comment.

In https://reviews.llvm.org/D36261#834902, @klimek wrote:

> High-level question: Why can't we use llvm::ThreadPool?


It is not an in-place replacement as it does not allow to prioritize new tasks over old ones (new tasks are usually more important for clangd as the old ones are often outdated when new ones are added).
I looked into using `llvm::ThreadPool` before, but decided to stay with our own implementation.
It gives us more flexibility over threading and it is not hard to maintain (I think it's under 100 lines of code, and the code is rather simple).


https://reviews.llvm.org/D36261





More information about the cfe-commits mailing list