[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 17:13:46 PDT 2017


dexonsmith added a comment.

Oh, also found a couple of things you should likely split into prep commits to simplify this patch.



================
Comment at: src/cxa_demangle.cpp:1575-1577
-    sub_type names;
-    template_param_type subs;
-    Vector<template_param_type> template_param;
----------------
- Why not rename `names` as well?
- Please rename these in a separate prep commit to minimize noise on the final patch.


https://reviews.llvm.org/D36427





More information about the cfe-commits mailing list