[PATCH] D36397: [clangd] Fixed a data race.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 07:51:59 PDT 2017


ilya-biryukov created this revision.

Calling addDocument after removeDocument could have resulted in an
invalid program state (AST and Preamble for the valid document could
have been incorrectly removed).
This commit also includes an improved CppFile::cancelRebuild
implementation that allows to cancel reparse without waiting for
ongoing rebuild to finish.


https://reviews.llvm.org/D36397

Files:
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36397.109993.patch
Type: text/x-patch
Size: 9475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170807/510ede75/attachment-0001.bin>


More information about the cfe-commits mailing list