[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.
Yan Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 4 10:50:42 PDT 2017
yawanng added inline comments.
================
Comment at: clang-tidy/android/CloexecCheck.h:72
+ StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result,
+ int n);
+
----------------
hokein wrote:
> `n` should be capital `N`. I think we can make it a const member method. And I can't see any usage of this method in this patch.
It's not used in this one, but in others.
https://reviews.llvm.org/D35372
More information about the cfe-commits
mailing list