[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

Vlad Tsyrklevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 17:52:28 PDT 2017


vlad.tsyrklevich marked an inline comment as done.
vlad.tsyrklevich added inline comments.


================
Comment at: lib/CodeGen/CodeGenFunction.cpp:789
+    auto *MD = dyn_cast_or_null<CXXMethodDecl>(D);
+    if (MD && MD->getName().equals("allocate") && MD->getNumParams() == 2) {
+      auto *BT = MD->parameters()[0]->getType()->getAs<BuiltinType>();
----------------
pcc wrote:
> Should this also match the C++17 allocate function which takes a single argument?
absolutely, thanks for catching this!


https://reviews.llvm.org/D36294





More information about the cfe-commits mailing list