[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 12:05:58 PDT 2017


sdardis added inline comments.


================
Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:6666
+          GVar->setLinkage(llvm::GlobalValue::ExternalLinkage);
+          GVar->setSection("rodata");
+        }
----------------
efriedma wrote:
> Also, this change is clearly unacceptable; among other things, messing with the linkage of static local variables is likely to lead to link errors.
I will fix that. 


Repository:
  rL LLVM

https://reviews.llvm.org/D35917





More information about the cfe-commits mailing list