[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

[Strahinja Petrovic via Phabricator via cfe-commits]

spetrovic added inline comments.


================
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136
+    if (ThreadPointer == ReadTPMode::Invalid &&
+        !StringRef(A->getValue()).empty()) {
+      D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
----------------
bruno wrote:
> What happens if you pass an empty "-mtp="  to the driver? Will it silently assume soft? Shouldn't it be an error too?
I agree, it should be an error, I fixed that.


Repository:
  rL LLVM

https://reviews.llvm.org/D34878