[PATCH] D34512: Add preliminary Cross Translation Unit support library
Krasimir Georgiev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 3 07:27:37 PDT 2017
krasimir added inline comments.
================
Comment at: include/clang/CrossTU/CrossTUDiagnostic.h:16
+namespace clang {
+ namespace diag {
+ enum {
----------------
LLVM Style uses no indent for namespaces. Reformat with `clang-format`.
================
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:70
+ llvm::StringMap<std::unique_ptr<clang::ASTUnit>> FileASTUnitMap;
+ llvm::StringMap<clang::ASTUnit *> FunctionAstUnitMap;
+ llvm::StringMap<std::string> FunctionFileMap;
----------------
Maybe rename to `FunctionASTUnitMap` for consistency with the previous line?
https://reviews.llvm.org/D34512
More information about the cfe-commits
mailing list